Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"#10072
Merged
Mousius merged 1 commit intoapache:mainfrom Jan 26, 2022
Merged
Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"#10072Mousius merged 1 commit intoapache:mainfrom
Mousius merged 1 commit intoapache:mainfrom
Conversation
…)" Because of the failure of LSTM conversion from Pytorch This reverts commit ce108c1.
chunit-quic
requested review from
Huyuwei,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
slyubomirsky,
srkreddy1238,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
FrozenGene
approved these changes
Jan 26, 2022
Member
|
Thanks for identifying this and raising the revert quickly @chunit-quic 😸 |
Contributor
Author
Hi @Mousius, Sorry that didn't identify this at the very begging. Quick update: |
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
…)" (apache#10072) Because of the failure of LSTM conversion from Pytorch
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…)" (apache#10072) Because of the failure of LSTM conversion from Pytorch
ghost
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 21, 2022
…)" (apache#10072) (#246) Because of the failure of LSTM conversion from Pytorch Co-authored-by: Chun-I Tsai <quic_chunit@quicinc.com>
ghost
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 21, 2022
…)" (apache#10072) (#246) Because of the failure of LSTM conversion from Pytorch Co-authored-by: Chun-I Tsai <quic_chunit@quicinc.com>
chunit-quic
pushed a commit
to chunit-quic/tvm
that referenced
this pull request
Mar 2, 2022
* ExprMutator without any change fails to mutate expressions during converting LSTM * [1]apache#9723 (comment) * [2]https://github.com/apache/tvm/blob/122be3fb18902bf2317797fedfa867dcf9607ef9/src/relay/transforms/de_duplicate.cc#L113 * [3] https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/src/ir/module.cc#L202 * [4] https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/python/tvm/relay/expr_functor.py#L216 * [5]apache#10072 * [6]apache#9723 (comment) * [7]https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/src/relay/transforms/de_duplicate.cc
chunit-quic
pushed a commit
to chunit-quic/tvm
that referenced
this pull request
Mar 4, 2022
* ExprMutator without any change fails to mutate expressions during converting LSTM * [1]apache#9723 (comment) * [2]https://github.com/apache/tvm/blob/122be3fb18902bf2317797fedfa867dcf9607ef9/src/relay/transforms/de_duplicate.cc#L113 * [3] https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/src/ir/module.cc#L202 * [4] https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/python/tvm/relay/expr_functor.py#L216 * [5]apache#10072 * [6]apache#9723 (comment) * [7]https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/src/relay/transforms/de_duplicate.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the failure the LSTM conversion from Pyotrch
#9723
This reverts commit ce108c1.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.