[MetaSchedule][M4a] User-API: Tune-TE/TIR/Relay#10079
Merged
Hzfengsy merged 2 commits intoapache:mainfrom Jan 30, 2022
Merged
Conversation
zxybazh
requested review from
Hzfengsy,
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
Member
|
Let's wait for the rest 3 rules to be upstreamed before merging this PR :-) |
62 tasks
junrushao
changed the title
junrushao
reviewed
Jan 27, 2022
zxybazh
force-pushed
the
meta-schedule/upstream/2022-01-26/tune-scripts
branch
from
490dfcc to
512ac20
Compare
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> Minor fix. Nits. Add back tests.
junrushao
force-pushed
the
meta-schedule/upstream/2022-01-26/tune-scripts
branch
from
512ac20 to
e213c9c
Compare
junrushao
reviewed
Jan 29, 2022
Comment on lines
+146
to
+151
| test_meta_schedule_tune_relay("resnet18", 1, "llvm --num-cores=16") | ||
| test_meta_schedule_tune_relay("resnet18", 1, "nvidia/geforce-rtx-3070") | ||
| test_meta_schedule_tune_relay("mobilenet_v2", 1, "llvm --num-cores=16") | ||
| test_meta_schedule_tune_relay("mobilenet_v2", 1, "nvidia/geforce-rtx-3070") | ||
| test_meta_schedule_tune_relay("bert_base", 1, "llvm --num-cores=16") | ||
| test_meta_schedule_tune_relay("bert_base", 1, "nvidia/geforce-rtx-3070") |
Member
There was a problem hiding this comment.
Wonder how long would these 6 unittests take in total?
Hzfengsy
approved these changes
Jan 30, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Add tuning scripts for tir, te & relay. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> Minor fix. Nits. Add back tests. * slightly improve tune.py Co-authored-by: Junru Shao <junrushao1994@gmail.com>
MasterJH5574
reviewed
Mar 3, 2022
| int running_tasks = tasks.size(); | ||
| for (int task_id; (task_id = NextTaskId()) != -1;) { | ||
| LOG(INFO) << "Scheduler picks Task #" << task_id << ": " << tasks[task_id]->task_name; | ||
| LOG(INFO) << "Scheduler picks Task #" << task_id + 1 << ": " << tasks[task_id]->task_name; |
Contributor
There was a problem hiding this comment.
Hi Xiyou! I'm curious about this change. After this change the printed ids at several places differ (here with + 1 while others without.)
Perhaps it's better to keep them consistent 👀?
Member
Author
There was a problem hiding this comment.
Hi, thanks for pointing that out. The reason for this change is previously we have task 0/18 to task 17/18 which seems confusing to me. I intend to make sure the log is consistent but I might missed a couple places. After second thoughts I think it might be better to keep the task_id the same way it is so that it would be easier for debugging later. See #10478.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the stage M4a of the meta schedule project (#8473).
The architecture is re-designed by Junru and Xiyou. In this PR we introduced the tuning scripts for tir, te & relay workloads with meta schedule. Unittests are added for each type of tuning, and for relay workloads we added tests of ResNet18, MobileNetV2 and BertBase.
Thanks to all co-authors for contributing!
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>