[BYOC-OpenCLML] OpenCLML integration with TVM.#10243
Merged
masahi merged 2 commits intoapache:mainfrom Jun 14, 2022
Merged
Conversation
srkreddy1238
requested review from
a team,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
liangfu,
manupak,
masahi,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tmoreau89,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
srkreddy1238
force-pushed
the
clml_upstream
branch
from
f302240 to
1c5cfaa
Compare
srkreddy1238
force-pushed
the
clml_upstream
branch
from
1c5cfaa to
b0c7555
Compare
srkreddy1238
force-pushed
the
clml_upstream
branch
from
b0c7555 to
f887c41
Compare
Contributor
|
@masahi can you take a look? |
Member
|
@srkreddy1238 Do you intend to get it merged? If so, please pass the CI |
Contributor
Author
|
@masahi working on it. Was occupied for some time. |
srkreddy1238
force-pushed
the
clml_upstream
branch
3 times, most recently
from
7e609ca to
222a74e
Compare
srkreddy1238
force-pushed
the
clml_upstream
branch
from
222a74e to
cbb8eda
Compare
Contributor
Author
|
@masahi good to go now :) |
masahi
requested changes
May 20, 2022
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
Please go through your code and improve code quality.
| LOG(WARNING) << "CLML engine is not initialized. " | ||
| << "Please build with USE_CLML_GRAPH_EXECUTOR."; | ||
| } | ||
| #endif |
Member
There was a problem hiding this comment.
Can we add a dummy runtime file for this case, rather than wrapping the entire 1k file under #ifdef TVM_GRAPH_EXECUTOR_CLML?
Contributor
Author
There was a problem hiding this comment.
Like clml_runtime_dummy.cc with bare min dependencies required for model compilation ? This is a common problem for all BYOC's. Do we create these stub sources under the same folder ?
srkreddy1238
force-pushed
the
clml_upstream
branch
3 times, most recently
from
97c84b5 to
8a36c25
Compare
srkreddy1238
force-pushed
the
clml_upstream
branch
from
8a36c25 to
349efd9
Compare
Contributor
Author
|
@masahi can you take another look ? |
masahi
approved these changes
Jun 14, 2022
|
Thank you for your amazing contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.