Skip to content

[microNPU] Some housekeeping in the test_ethosu folder#10824

Merged
manupak merged 3 commits intoapache:mainfrom
ekalda:refactor-test-codegen
Mar 31, 2022
Merged

[microNPU] Some housekeeping in the test_ethosu folder#10824
manupak merged 3 commits intoapache:mainfrom
ekalda:refactor-test-codegen

Conversation

@ekalda
Copy link
Copy Markdown
Contributor

@ekalda ekalda commented Mar 30, 2022

  • Move the utility functions from test_codegen.py into infra.py for
    wider accessibility
  • Remove some unused code
  • Make the conv2d codegen tests more general

@ekalda
Copy link
Copy Markdown
Contributor Author

ekalda commented Mar 30, 2022

@lhutton1 @manupa-arm @NicolaLancellotti an unglamorous refactor :)

Copy link
Copy Markdown
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @ekalda LGTM

ekalda added 2 commits March 30, 2022 16:45
* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general
@ekalda ekalda force-pushed the refactor-test-codegen branch from 5917e2f to 88537c5 Compare March 30, 2022 16:23
Copy link
Copy Markdown
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manupak manupak merged commit 8226bd0 into apache:main Mar 31, 2022
@manupak
Copy link
Copy Markdown
Contributor

manupak commented Mar 31, 2022

Thanks @ekalda for the refactor

pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder

* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general

* Update test_identity_optimizer.py

* Update test_lut_optimizer.py
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder

* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general

* Update test_identity_optimizer.py

* Update test_lut_optimizer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants