[CI] Update GoogleTest#11162
Merged
Mousius merged 2 commits intoapache:mainfrom May 3, 2022
Merged
Conversation
Mousius
force-pushed
the
better-googletest
branch
from
22bfcbf to
e5dd3bc
Compare
Mousius
force-pushed
the
better-googletest
branch
from
e5dd3bc to
17a7be0
Compare
Member
Author
|
@areusch I have, and I get the same number of seg faults, which isn't very encouraging for my local environment - need to see what happens in CI here |
Mousius
force-pushed
the
better-googletest
branch
from
17a7be0 to
b8717d3
Compare
Mousius
force-pushed
the
better-googletest
branch
2 times, most recently
from
316e06b to
94ea21c
Compare
This updates GoogleTest across all our images which also has the side effect of using the same version for any host OS. Rather than updating to a fixed version, I've followed the best practice advertised by GoogleTest itself which is the Live-at-Head philosophy: https://github.com/google/googletest#live-at-head Closes apache#11002
This is needed to make many public HTTPS requests and it's likely installed as a side effect right now.
Member
Author
|
Update on the above, I found it was |
7 tasks
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
May 4, 2022
Looks like I missed this one in apache#11162 due to missing the cpptest call in the Jenkinsfile
Mousius
added a commit
that referenced
this pull request
May 4, 2022
Looks like I missed this one in #11162 due to missing the cpptest call in the Jenkinsfile
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This updates GoogleTest across all our images which also has the side effect of using the same version for any host OS. Rather than updating to a fixed version, I've followed the best practice advertised by GoogleTest itself which is the Live-at-Head philosophy: https://github.com/google/googletest#live-at-head Closes apache#11002
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
Looks like I missed this one in apache#11162 due to missing the cpptest call in the Jenkinsfile
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
This updates GoogleTest across all our images which also has the side effect of using the same version for any host OS. Rather than updating to a fixed version, I've followed the best practice advertised by GoogleTest itself which is the Live-at-Head philosophy: https://github.com/google/googletest#live-at-head Closes apache#11002
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
Looks like I missed this one in apache#11162 due to missing the cpptest call in the Jenkinsfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates GoogleTest across all our images which also has the side
effect of using the same version for any host OS.
Rather than updating to a fixed version, I've followed the best practice
advertised by GoogleTest itself which is the Live-at-Head philosophy:
https://github.com/google/googletest#live-at-head
Closes #11002
cc @areusch @driazati