Skip to content

[Hexagon] moves conftest.py to tvm.contrib.hexagon so outside repos can access the testing fixtures#11277

Merged
mehrdadh merged 2 commits intoapache:mainfrom
farshidsp:farshidsp/hexagon/cleanup_directory
May 19, 2022
Merged

[Hexagon] moves conftest.py to tvm.contrib.hexagon so outside repos can access the testing fixtures#11277
mehrdadh merged 2 commits intoapache:mainfrom
farshidsp:farshidsp/hexagon/cleanup_directory

Conversation

@farshidsp
Copy link
Copy Markdown
Contributor

  • Copied the content of conftest.py to tvm.contrib.hexagon.pytest_plugin --> Outside repos can now access the hexagon specific fixtures.

  • Modified the conftest.py to only import the tvm.contrib.hexagon.pytest_plugin

  • Modified all the hexagon tests to import requires_hexagon_toolchain from tvm.contrib.hexagon.pytest_plugin

@Lunderberg @mehrdadh @csullivan

Comment thread python/tvm/contrib/hexagon/pytest_plugin.py Outdated
Comment thread tests/python/contrib/test_hexagon/unit_tests.py Outdated
Comment thread tests/python/contrib/test_hexagon/unit_tests.py Outdated
Copy link
Copy Markdown
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@farshidsp farshidsp requested a review from mehrdadh May 18, 2022 20:09
Copy link
Copy Markdown
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

from tvm.contrib.hexagon.session import Session
from tvm.testing.usmp import is_tvm_backendallocworkspace_calls

from .conftest import requires_hexagon_toolchain
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change this to require_hexagon in a follow up PR.

@mehrdadh mehrdadh merged commit 8d0da24 into apache:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants