[Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint#11412
Merged
junrushao merged 1 commit intoapache:mainfrom May 23, 2022
Merged
[Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint#11412junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
Follow-up from apache#11235, all error messages should be based on expressions that are not IterMapExpr.
vinx13
approved these changes
May 23, 2022
Member
|
Shall we have a regression test over this? Thanks a lot! |
Member
|
Maybe not. It's more related to error reporting |
Contributor
Author
|
Unfortunately, it does cause issues beyond error reporting. By attempting to print an unsupported type, this bug called Which is all to say that I've made a regression test, and am going to open a PR to add it. |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 23, 2022
Follow-up from apache#11412, adding a regression test for the bugfix.
junrushao
pushed a commit
that referenced
this pull request
May 24, 2022
Follow-up from #11412, adding a regression test for the bugfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #11235, all error messages should be based on expressions that are not IterMapExpr.
cc @vinx13