[microNPU] Add transform matrices and part matcher to identity op#11453
[microNPU] Add transform matrices and part matcher to identity op#11453lhutton1 merged 4 commits intoapache:mainfrom
Conversation
NicolaLancellotti
force-pushed
the
cascader/identity
branch
from
1c56d16 to
0270967
Compare
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Thanks @NicolaLancellotti, looks good in general! Just some comments about mapping 3D tensors to NHWC.
|
(I don't know why it displays each comment twice 😅 ) |
NicolaLancellotti
force-pushed
the
cascader/identity
branch
from
0270967 to
b94afca
Compare
No, problem. Thanks, @ekalda for the review. |
|
Hi @NicolaLancellotti , It would be great to rebase this PR on top of https://github.com/apache/tvm/pull/11410/files and see if the unit tests that I have disabled in that PR works -- so we can have higher confidence about the changes in this PR. |
NicolaLancellotti
force-pushed
the
cascader/identity
branch
from
b94afca to
30c69d1
Compare
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Looking forward to the rebase :) just a couple of small things that might be worth including?
|
|
||
| subkernels = len(device_config.get_kernel_steps(identity.op.name, 1, 1, ifm_dtype)) | ||
|
|
||
| input_layout = output_layout = "NHWC" |
There was a problem hiding this comment.
Perhaps we should assert that len(input_tensors_shape) <= 4 if we don't support brick layout for identity
There was a problem hiding this comment.
Ah, apologies, I should have said that a message would have been helpful alongside the assert as well. Lets take it in a follow up :)
|
|
||
| subkernels = len(device_config.get_kernel_steps(identity.op.name, 1, 1, ifm_dtype)) | ||
|
|
||
| input_layout = output_layout = "NHWC" |
There was a problem hiding this comment.
Ah, apologies, I should have said that a message would have been helpful alongside the assert as well. Lets take it in a follow up :)
|
Thanks @NicolaLancellotti, @ekalda, @manupa-arm! |
4 participants
This commit adds support for the identity operator in the cascader.
@manupa-arm @ekalda @lhutton1
cc @Mousius