[Target] Add Target Parser for Arm(R) Cortex(R) A-Profile CPUs#12454
[Target] Add Target Parser for Arm(R) Cortex(R) A-Profile CPUs#12454Mousius merged 5 commits intoapache:mainfrom
Conversation
|
cc @u99127 for review 😸 |
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
a8f7ba2 to
2184d2e
Compare
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
2184d2e to
29a3843
Compare
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
|
It has been a while since this PR was updated, @u99127 please leave a review or address the outstanding comments. @Mousius if this PR is still a work in progress, please convert it to a draft until it is ready for review. |
29a3843 to
4ff0fc4
Compare
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
|
It has been a while since this PR was updated, @u99127 please leave a review or address the outstanding comments. @Mousius if this PR is still a work in progress, please convert it to a draft until it is ready for review. |
|
It has been a while since this PR was updated, @u99127 please leave a review or address the outstanding comments. @Mousius if this PR is still a work in progress, please convert it to a draft until it is ready for review. |
1 similar comment
|
It has been a while since this PR was updated, @u99127 please leave a review or address the outstanding comments. @Mousius if this PR is still a work in progress, please convert it to a draft until it is ready for review. |
u99127
left a comment
There was a problem hiding this comment.
Sorry about the time it has taken to get around to this :)
If I could request a few changes , then I'm good .
This implements an initial Target Parser which aims to consolidate architecture feature detection from a few different places: * https://github.com/apache/tvm/blob/d2db9cb0d839e32778f461b77e59f6418282a511/python/tvm/topi/arm_cpu/arm_utils.py#L24-L70 * https://github.com/apache/tvm/blob/02fbaf0ed9120a8f95155e63de42459f230584aa/python/tvm/relay/qnn/op/legalizations.py#L350-L359 * https://github.com/apache/tvm/blob/b542724873140bb051492530d97a78b9b7b7983d/python/tvm/relay/op/strategy/arm_cpu.py#L232 A further patch will remove all of the above and replace usages with the `.features` map.
4ff0fc4 to
85ab2a3
Compare
Following on from #12454 this patch removes the utility functions in favour of the centralised `target.features` property.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
Following on from #12454 this patch removes the utility functions in favour of the centralised `target.features` property.
…e#12454) This implements an initial Target Parser which aims to consolidate architecture feature detection from a few different places: * https://github.com/apache/tvm/blob/d2db9cb0d839e32778f461b77e59f6418282a511/python/tvm/topi/arm_cpu/arm_utils.py#L24-L70 * https://github.com/apache/tvm/blob/02fbaf0ed9120a8f95155e63de42459f230584aa/python/tvm/relay/qnn/op/legalizations.py#L350-L359 * https://github.com/apache/tvm/blob/b542724873140bb051492530d97a78b9b7b7983d/python/tvm/relay/op/strategy/arm_cpu.py#L232 A further patch will remove all of the above and replace usages with the `.features` map.
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
…e#12454) This implements an initial Target Parser which aims to consolidate architecture feature detection from a few different places: * https://github.com/apache/tvm/blob/d2db9cb0d839e32778f461b77e59f6418282a511/python/tvm/topi/arm_cpu/arm_utils.py#L24-L70 * https://github.com/apache/tvm/blob/02fbaf0ed9120a8f95155e63de42459f230584aa/python/tvm/relay/qnn/op/legalizations.py#L350-L359 * https://github.com/apache/tvm/blob/b542724873140bb051492530d97a78b9b7b7983d/python/tvm/relay/op/strategy/arm_cpu.py#L232 A further patch will remove all of the above and replace usages with the `.features` map.
Following on from apache#12454 this patch removes the utility functions in favour of the centralised `target.features` property.
This implements an initial Target Parser which aims to consolidate architecture feature detection from a few different places:
tvm/python/tvm/topi/arm_cpu/arm_utils.py
Lines 24 to 70 in d2db9cb
tvm/python/tvm/relay/qnn/op/legalizations.py
Lines 350 to 359 in 02fbaf0
tvm/python/tvm/relay/op/strategy/arm_cpu.py
Line 232 in b542724
A further patch will remove all of the above and replace usages with the
.featuresmap.