[AutoTVM] Introducing multi_filter into ConfigSpace autotvm#12545
Merged
masahi merged 2 commits intoapache:mainfrom Sep 22, 2022
Merged
[AutoTVM] Introducing multi_filter into ConfigSpace autotvm#12545masahi merged 2 commits intoapache:mainfrom
masahi merged 2 commits intoapache:mainfrom
Conversation
1585196 to
6578df8
Compare
Contributor
Author
|
CC @merrymercy @eqy |
|
cc @csullivan |
Icemist
commented
Sep 2, 2022
echuraev
reviewed
Sep 5, 2022
Contributor
There was a problem hiding this comment.
Quickly looked into this PR. I don't really like that now we need to call tsk.config_space.filtered_length instead of len(tsk.config_space). I think that len(smth) is more intuitive. But I didn't dive deeply into the details. I'll do it later. I think that @elvin-n can provide more useful and detailed review.
elvin-n
suggested changes
Sep 9, 2022
5da9a68 to
5b85a2d
Compare
bb9c460 to
c800055
Compare
elvin-n
suggested changes
Sep 13, 2022
c800055 to
011b59e
Compare
elvin-n
approved these changes
Sep 13, 2022
Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com Co-authored-by: Egor Churaev egor.churaev@gmail.com
011b59e to
e88f350
Compare
elvin-n
approved these changes
Sep 16, 2022
e88f350 to
7c68a30
Compare
7c68a30 to
bbbed0f
Compare
elvin-n
approved these changes
Sep 16, 2022
Contributor
|
@masahi @merrymercy could you please take a look? |
Contributor
|
CC @tqchen @merrymercy this PR makes some in depth changes to autoTVM, PTAL |
vinx13
approved these changes
Sep 16, 2022
Contributor
|
can we merge this PR into main? |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…2545) * [AutoTVM] Introducing multi_filter into ConfigSpace autotvm Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com Co-authored-by: Egor Churaev egor.churaev@gmail.com * update multi_filter for adreno conv's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_filter can restrict combination of parameters in difference to the knob filter, that restricts only single parameter.
Here is a small example to show the workflow and the difference:
Pre-requisites
Case 1 - without filtering
Case 2 - with filter
Case 3 - with filter and multi_filter
Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com
Co-authored-by: Egor Churaev egor.churaev@gmail.com