[ci] Add mechanism for trust on certain CI scripts#12604
Merged
driazati merged 1 commit intoapache:mainfrom Aug 30, 2022
driazati:jtrust
Merged
[ci] Add mechanism for trust on certain CI scripts#12604driazati merged 1 commit intoapache:mainfrom driazati:jtrust
driazati merged 1 commit intoapache:mainfrom
driazati:jtrust
Conversation
Contributor
areusch
reviewed
Aug 25, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
mainly one question, which i think related to the test script refactor
7 tasks
This makes it so changes to certain files from users not listed in `CONTRIBUTING.md` are not tested in CI. This is necessary since these scripts run on the baremetal EC2 instances and not inside Docker containers, so they can affect other builds and potentially grab Jenkins secrets. This checks out the version from the upstream for the listed files after running `git checkout`.
areusch
approved these changes
Aug 30, 2022
areusch
pushed a commit
that referenced
this pull request
Sep 15, 2022
This should mitigate failures like in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4274/pipeline. This also moves the `retry` function to a script now that we have PR #12604. Co-authored-by: driazati <driazati@users.noreply.github.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This makes it so changes to certain files from users not listed in `CONTRIBUTING.md` are not tested in CI. This is necessary since these scripts run on the baremetal EC2 instances and not inside Docker containers, so they can affect other builds and potentially grab Jenkins secrets. This checks out the version from the upstream for the listed files after running `git checkout`. Tested in CI: [positive](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12604/6/pipeline/) and [negative](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12604/9/pipeline/)
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This should mitigate failures like in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4274/pipeline. This also moves the `retry` function to a script now that we have PR apache#12604. Co-authored-by: driazati <driazati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so changes to certain files from users not listed in
CONTRIBUTING.mdare not tested in CI. This is necessary since thesescripts run on the baremetal EC2 instances and not inside Docker
containers, so they can affect other builds and potentially grab Jenkins
secrets. This checks out the version from the upstream for the listed
files after running
git checkout. Tested in CI: positive and negativecc @Mousius @areusch @gigiblender