[microTVM][PyTorch][Tutorial]Adding a PyTorch tutorial for microTVM with CRT by mehrdadh · Pull Request #13324 · apache/tvm

mehrdadh · 2022-11-08T17:24:29Z

This PR adds a tutorial to compile/run a PyTorch model using microTVM CRT.

tvm-bot · 2022-11-08T17:24:33Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @alanmacd, @gromero, @yelite _{See #10317 for details}
Built docs for commit 19d87dd can be found here.

_{Generated by tvm-bot}

tvm-bot · 2022-11-08T17:24:33Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @alanmacd, @gromero, @yelite _{See #10317 for details}

_{Generated by tvm-bot}

alanmacd

this is great, thanks for writing it up!

alanmacd · 2022-11-08T17:55:37Z


 IS_TEMPLATE = not os.path.exists(os.path.join(PROJECT_DIR, MODEL_LIBRARY_FORMAT_RELPATH))

+MEMORY_SIZE_BYTES = 2 * 1024 * 1024


nit: maybe add comment as to why this is default memory size

added, it's not an interesting reason. It's basically chosen to pass CRT tests in TVM

@mehrdadh I think that's actually interesting / important info: the constant is determined experimentally, it's really good to have comment about it as @alanmacd requested, I don't even consider it a nit :-)

gromero

@mehrdadh Thanks for the tutorial! Nice.

I just have nits (see inline) and one question:

Could we add Wno-unused-variable flag to MODEL_CFLAGS? like:

diff --git a/src/runtime/crt/host/Makefile.template b/src/runtime/crt/host/Makefile.template
index a8e725ade..2caf7ba0b 100644
--- a/src/runtime/crt/host/Makefile.template
+++ b/src/runtime/crt/host/Makefile.template
@@ -22,7 +22,7 @@ CXXFLAGS ?= -Werror -Wall -std=c++11 -DTVM_HOST_USE_GRAPH_EXECUTOR_MODULE -DMEMO
 LDFLAGS ?= -Werror -Wall
 
 # Codegen produces spurious lines like: int32_t arg2_code = ((int32_t*)arg_type_ids)[(2)];
-MODEL_CFLAGS ?= -Wno-error=unused-variable -Wno-error=missing-braces -Wno-error=unused-const-variable
+MODEL_CFLAGS ?= -Wno-error=unused-variable -Wno-error=missing-braces -Wno-error=unused-const-variable -Wno-unused-variable
 
 AR ?= ${PREFIX}ar
 CC ?= ${PREFIX}gcc

Otherwise I get bazillions of unused variables warnings when I run the script which is not encouraging for people running / exploring the tutorial for the first time. -Wno-error=unused-variable is not enough to silence it. wdyt?

gromero · 2022-11-08T22:02:37Z

+# Define Target, Runtime and Executor
+# -------------------------------
+#
+# In this tutorial we use AOT host driven executor. To compile the model


nit: host-driven?

gromero · 2022-11-08T22:03:37Z

+from tvm.contrib.download import download_testdata
+from tvm.relay.backend import Executor
+
+#################################


nit: add one more # to "cover" the line below?

gromero · 2022-11-08T22:04:04Z

+
+#################################
+# Load a pre-trained PyTorch model
+# -------------------------------


nit: add one more - to match end of line above?

gromero · 2022-11-08T22:05:08Z

+shape_list = [(input_name, input_shape)]
+relay_mod, params = relay.frontend.from_pytorch(scripted_model, shape_list)
+
+#################################


nit: add more # chars to "cover" end of line below?

gromero · 2022-11-08T22:05:35Z

+
+#################################
+# Define Target, Runtime and Executor
+# -------------------------------


nit: add enough - chars to align this to the end of line above?

gromero · 2022-11-08T22:05:51Z

+# -------------------------------
+#
+# In this tutorial we use AOT host driven executor. To compile the model
+# for an emulated embedded environment on an X86 machine we use C runtime (CRT)


gromero · 2022-11-08T22:06:39Z

+# In this tutorial we use AOT host driven executor. To compile the model
+# for an emulated embedded environment on an X86 machine we use C runtime (CRT)
+# and we use `host` micro target. Using this setup, TVM compiles the model
+# for C runtime which can run on a X86 CPU machine with the same flow that


same here: x86 instead of X86

gromero · 2022-11-08T23:11:23Z

+
+
+# Simulate a microcontroller on the host machine. Uses the main() from `src/runtime/crt/host/main.cc`
+# To use physical hardware, replace "host" with something matching your hardware.


How about instead of using "something'" say "replace 'hosts' with another physical micro target, e.g. 'nrf52840' or 'mps2_an521' -- see more more target examples in micro_train.py and micro_tflite.py tutorials "?

mehrdadh · 2022-11-08T23:51:01Z

@gromero that's a good point. I added that compiler flag.

gromero

@mehrdadh Thanks, LGTM.

…pache#13324) This commit adds a tutorial to compile and run a PyTorch model using microTVM, the AOT host-driven executor, and C runtime (CRT).

mehrdadh requested a review from gromero November 8, 2022 17:24

alanmacd approved these changes Nov 8, 2022

View reviewed changes

mehrdadh added 3 commits November 8, 2022 13:32

[microTVM] Add Pytorch tutorial

58e4497

update tutorial

7acff25

add comment

091d332

mehrdadh force-pushed the microtvm/pytorch_tutorial branch from b7e242a to 091d332 Compare November 8, 2022 21:32

fix hook

5284076

mehrdadh force-pushed the microtvm/pytorch_tutorial branch from b1de307 to 5284076 Compare November 8, 2022 22:14

gromero requested changes Nov 8, 2022

View reviewed changes

mehrdadh added 2 commits November 8, 2022 15:42

remove warning on unsed variable

39aa4df

address comments

f34d3b8

mehrdadh added 3 commits November 8, 2022 16:01

remove torch warninigs

31a8aea

fix format

0e12e41

cleanup micro_aot.py

19d87dd

gromero approved these changes Nov 9, 2022

View reviewed changes

gromero merged commit fbe174b into apache:main Nov 9, 2022

mehrdadh deleted the microtvm/pytorch_tutorial branch November 9, 2022 16:44

leandron mentioned this pull request Feb 1, 2023

TVM v0.11.0 Release Candidate Notes #13899

Closed


		IS_TEMPLATE = not os.path.exists(os.path.join(PROJECT_DIR, MODEL_LIBRARY_FORMAT_RELPATH))

		MEMORY_SIZE_BYTES = 2 * 1024 * 1024



		# Simulate a microcontroller on the host machine. Uses the main() from `src/runtime/crt/host/main.cc`
		# To use physical hardware, replace "host" with something matching your hardware.

Conversation

mehrdadh commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvm-bot commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvm-bot commented Nov 8, 2022

Uh oh!

alanmacd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gromero Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gromero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mehrdadh commented Nov 8, 2022

Uh oh!

gromero left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mehrdadh commented Nov 8, 2022 •

edited

Loading

tvm-bot commented Nov 8, 2022 •

edited

Loading

gromero Nov 8, 2022 •

edited

Loading