[Target] Make key=arm_cpu --> key=arm_cpu,cpu on AArch64#13775
Merged
AndrewZhaoLuo merged 3 commits intoapache:mainfrom Jan 13, 2023
Merged
[Target] Make key=arm_cpu --> key=arm_cpu,cpu on AArch64#13775AndrewZhaoLuo merged 3 commits intoapache:mainfrom
key=arm_cpu --> key=arm_cpu,cpu on AArch64#13775AndrewZhaoLuo merged 3 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Mousius
approved these changes
Jan 12, 2023
Member
Mousius
left a comment
There was a problem hiding this comment.
Argh, this was an unintended side effect of #12474, thanks for fixing this @AndrewZhaoLuo!
key=arm_cpu --> key=arm_cpu,cpukey=arm_cpu --> key=arm_cpu,cpu on AArch64
asparkhi
pushed a commit
to asparkhi/tvm
that referenced
this pull request
Mar 10, 2023
…ncatenate NPU used generic implementation for concatenate before cpu schedules were made the default fallback schedules. This leads to performance degradation as this blocks fusion with nearby ops. This commit adds Relay op strategy for arm_cpu implementation which makes it use arm_cpu schedule before cpu one. Reference: apache#13775 Co-authored-by: Luke Hutton <luke.hutton@arm.com> Change-Id: If6e65d74309702daf1f837a24e7b19c2912d0d9c
asparkhi
pushed a commit
to asparkhi/tvm
that referenced
this pull request
Mar 10, 2023
…atenate NPU used generic implementation for concatenate before cpu schedules were made the default fallback schedules. This leads to performance degradation as this blocks fusion with nearby ops. This commit adds Relay op strategy for arm_cpu implementation which makes it use arm_cpu schedule before cpu one. Reference: apache#13775 Co-authored-by: Luke Hutton <luke.hutton@arm.com> Change-Id: If6e65d74309702daf1f837a24e7b19c2912d0d9c
asparkhi
pushed a commit
to asparkhi/tvm
that referenced
this pull request
Mar 14, 2023
…atenate NPU used generic implementation for concatenate before cpu schedules were made the default fallback schedules. This leads to performance degradation as this blocks fusion with nearby ops. This commit adds Relay op strategy for arm_cpu implementation which makes it use arm_cpu schedule before cpu one. Reference: apache#13775 Co-authored-by: Luke Hutton <luke.hutton@arm.com>
lhutton1
added a commit
that referenced
this pull request
Mar 14, 2023
…oncat (#14270) Previously used generic implementation for concatenate before cpu schedules were made the default fallback schedules. This leads to performance degradation as this blocks fusion with nearby ops. This commit adds Relay op strategy for arm_cpu implementation which makes it use arm_cpu schedule before cpu one. Reference: #13775 Co-authored-by: Luke Hutton <luke.hutton@arm.com>
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…13775) * arm cpu is cpu * init commit * fix test
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Aug 3, 2023
Currently the fallback used when compiling a dense operation with targets such as `llvm -device=arm_cpu` is `dense.generic`. This results very poor performance. Although apache#13775 meant that x86 schedules are used in cases where no strategy is provided by arm_cpu, the dense strategy is registered due to the existance of specialized schedules for arm_cpu e.g. a schedule for embedded devices. This commit ensures x86 schedules are used inplace of a generic schedule which yeilds much better performance. The commit also follows the same approach for the `dense.generic` schedule as the x86 strategy. This will only be used when autoscheduler is enabled. A test has been added to check the intended schedules are picked when compiling with `arm_cpu`. Change-Id: I8697f630d4acfab71a9626cf9e0dc3086987f163
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Aug 4, 2023
Currently the fallback used when compiling a dense operation with targets such as `llvm -device=arm_cpu` is `dense.generic`. This results very poor performance. Although apache#13775 meant that x86 schedules are used in cases where no strategy is provided by arm_cpu, the dense strategy is registered due to the existance of specialized schedules for arm_cpu e.g. a schedule for embedded devices. This commit ensures x86 schedules are used inplace of a generic schedule which yeilds much better performance. The commit also follows the same approach for the `dense.generic` schedule as the x86 strategy. This will only be used when autoscheduler is enabled. A test has been added to check the intended schedules are picked when compiling with `arm_cpu`. Change-Id: I8697f630d4acfab71a9626cf9e0dc3086987f163
leandron
pushed a commit
that referenced
this pull request
Aug 7, 2023
Currently the fallback used when compiling a dense operation with targets such as `llvm -device=arm_cpu` is `dense.generic`. This results very poor performance. Although #13775 meant that x86 schedules are used in cases where no strategy is provided by arm_cpu, the dense strategy is registered due to the existance of specialized schedules for arm_cpu e.g. a schedule for embedded devices. This commit ensures x86 schedules are used inplace of a generic schedule which yeilds much better performance. The commit also follows the same approach for the `dense.generic` schedule as the x86 strategy. This will only be used when autoscheduler is enabled. A test has been added to check the intended schedules are picked when compiling with `arm_cpu`. Change-Id: I8697f630d4acfab71a9626cf9e0dc3086987f163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keyin a target is used in dispatching to different strategies.In most of the code base
arm_cpuimplies also havingcpu. E.g. inpython/tvm/target/target.py:In
src/target/parsers/mprofile.cc:However A-series targets did not have both
arm_cpuandcpukeys. Rather they only hadarm_cpukeys. This PR makes it so it includes both, matching everywhere else in codebase.This also may lead to increased performance speedups as previously A-series targets would dispatch to generic strategy instead of cpu optimized strategy. With this, they should properly dispatch to
arm_cpustrategy, and fallback tocpustrategy.