[TOPI][Target] Add SVE specific convolution#14483
Merged
Mousius merged 1 commit intoapache:mainfrom May 17, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
FranklandJack
force-pushed
the
conv2d_sve_sched
branch
from
3891feb to
44924b6
Compare
Mousius
requested changes
Apr 4, 2023
FranklandJack
force-pushed
the
conv2d_sve_sched
branch
from
44924b6 to
1f34967
Compare
ekalda
reviewed
Apr 5, 2023
FranklandJack
force-pushed
the
conv2d_sve_sched
branch
from
1f34967 to
ba89009
Compare
Mousius
requested changes
Apr 19, 2023
FranklandJack
force-pushed
the
conv2d_sve_sched
branch
from
1f7a2a1 to
0bcea53
Compare
This commit will: * Expose SVE as a target feature for Arm(R) Cortex(R) A-Profile CPUs. * Update the compute definition of `conv2d_spatial_pack_nhwc` to defer to the LLVM backend for vectorization when compiling on an SVE enabled target for data tensors with unit width and height since this has been shown to be performant for wide vector architectures. * Add a target test to `cpptest` for Arm(R) Cortex(R) A-Profile CPUs which tests that the `has_sve` flag is set when the user explicitly passes the `"+sve"` attribute on target creation. Because SVE is optional on architecture versions 8.0 and later the test checks whether it is optionally set. * Make some pre-existing read only target properties constant. Change-Id: I7fef5c7e19da8aa140e61b28c26683c8467853fb
FranklandJack
force-pushed
the
conv2d_sve_sched
branch
from
0bcea53 to
eb07e7d
Compare
Contributor
|
LGTM! |
ekalda
approved these changes
May 17, 2023
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Thanks @FranklandJack, LGTM!
@Mousius I believe your comments are addressed, do you want to take a look again?
Member
|
@FranklandJack this has now landed, thank you for this awesome patch and your patience with the reviews 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will:
conv2d_spatial_pack_nhwcto defer to the LLVM backend for vectorization when compiling on an SVE enabled target for data tensors with unit width and height since this has been shown to be performant for wide vector architectures.