[Node] Allow alternative root names in ObjectPath::Root()#14569
Merged
tqchen merged 2 commits intoapache:mainfrom Apr 12, 2023
Merged
[Node] Allow alternative root names in ObjectPath::Root()#14569tqchen merged 2 commits intoapache:mainfrom
tqchen merged 2 commits intoapache:mainfrom
Conversation
Previously, the `ObjectPath` utility allowed tracking of an object's location within a tree-like structure. However, the base of the path structure was hard-coded to be the string `<root>`. For use cases such as `StructuralEqual`, there is a clear root node. However, other cases such as using `ObjectPath` to specify an object's location relative to a known variable, would require using that known variable's name as the root, rather than the hard-coded string `<root>`. This commit adds an optional parameter to provide an alternative name for the root node, to allow for these use cases.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
ObjectPathutility allowed tracking of an object's location within a tree-like structure. However, the base of the path structure was hard-coded to be the string<root>. For use cases such asStructuralEqual, there is a clear root node. However, other cases such as usingObjectPathto specify an object's location relative to a known variable, would require using that known variable's name as the root, rather than the hard-coded string<root>.This commit adds an optional parameter to provide an alternative name for the root node, to allow for these use cases.