[Fix][TIR][Analysis] Reduction block checking alloc_buffers#14589
Merged
tqchen merged 1 commit intoapache:mainfrom Apr 11, 2023
Merged
[Fix][TIR][Analysis] Reduction block checking alloc_buffers#14589tqchen merged 1 commit intoapache:mainfrom
tqchen merged 1 commit intoapache:mainfrom
Conversation
Previously the check of reduction block did not take the intermediate allocated buffers (that is, the buffers in `alloc_buffers` field of a block) into consideration, which will lead to exception thrown during scheduling in cases of nested block + cache read/write. This PR fixes this issue with one unit test for the DecomposeReduction primitive. Credit of the fix goes to Bohan. Co-authored-by: Bohan Hou <spectrometerh@gmail.com>
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
MasterJH5574
added a commit
to mlc-ai/relax
that referenced
this pull request
Apr 11, 2023
…ers (apache/tvm#14589) (#188) Previously the check of reduction block did not take the intermediate allocated buffers (that is, the buffers in `alloc_buffers` field of a block) into consideration, which will lead to exception thrown during scheduling in cases of nested block + cache read/write. This PR fixes this issue with one unit test for the DecomposeReduction primitive. Credit of the fix goes to Bohan. Co-authored-by: Bohan Hou <spectrometerh@gmail.com>
tqchen
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the check of reduction block did not take the intermediate allocated buffers (that is, the buffers in
alloc_buffersfield of a block) into consideration, which will lead to exception thrown during scheduling in cases of nested block + cache read/write.This PR fixes this issue with one unit test for the DecomposeReduction primitive.
Credit of the fix goes to Bohan.
Co-authored-by: Bohan Hou spectrometerh@gmail.com