Skip to content

[ARITH][TensorIR] Improve CompactBufferRegion for symbolic shape#14596

Merged
junrushao merged 1 commit intoapache:mainfrom
tqchen:compact
Apr 12, 2023
Merged

[ARITH][TensorIR] Improve CompactBufferRegion for symbolic shape#14596
junrushao merged 1 commit intoapache:mainfrom
tqchen:compact

Conversation

@tqchen
Copy link
Copy Markdown
Member

@tqchen tqchen commented Apr 11, 2023

This PR improves compact buffer region for symbolic shape programs. We introduce a new function CanProveLessEqualThanSymbolicShapeValue which can take the extra information such that rhs is a non-negative shape.

The change is necessary to enable symbolic shape schedules. Test cases are added to cover the case

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Apr 11, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen
Copy link
Copy Markdown
Member Author

tqchen commented Apr 11, 2023

cc @junrushao @wrongtest-intellif

@tqchen tqchen force-pushed the compact branch 2 times, most recently from e3d5e32 to 8294d56 Compare April 12, 2023 02:06
Comment thread src/tir/transforms/compact_buffer_region.cc Outdated
@junrushao
Copy link
Copy Markdown
Member

rebased against main

Copy link
Copy Markdown
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need some extra eyes from @wrongtest-intellif

This PR improves compact buffer region for symbolic shape programs.
We introduce a new function CanProveLessEqualThanSymbolicShapeValue
which can take the extra information such that rhs is a non-negative shape.

The change is necessary to enable symbolic shape schedules.
Test cases are added to cover the case
@junrushao junrushao merged commit ab93b31 into apache:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants