Skip to content

[CODEGEN] Fix metal codegen when with only single working dim #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spectrometerHBH merged 1 commit into from
Apr 16, 2023
Merged

[CODEGEN] Fix metal codegen when with only single working dim #14628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/target/source/codegen_metal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ void CodeGenMetal::AddFunction(const PrimFunc& f) {
PrintType(DataType::UInt(thread_index_bits_, work_dim), stream);
stream << " threadIdx [[thread_position_in_threadgroup]]\n";
}
thread_work_dim_ = work_dim;

// the function scope.
stream << ") {\n";
int func_scope = this->BeginScope();
Expand All @@ -158,8 +160,14 @@ void CodeGenMetal::AddFunction(const PrimFunc& f) {

void CodeGenMetal::BindThreadIndex(const IterVar& iv) {
ICHECK(!var_idmap_.count(iv->var.get()));
// if we only have threadIdx.x
// metal will directly print as threadIdx
std::string vname = iv->thread_tag;
if (thread_work_dim_ <= 1) {
vname = vname.substr(0, iv->thread_tag.length() - 2);
}
var_idmap_[iv->var.get()] =
CastFromTo(iv->thread_tag, DataType::UInt(thread_index_bits_), iv->var.dtype());
CastFromTo(vname, DataType::UInt(thread_index_bits_), iv->var.dtype());
}

void CodeGenMetal::PrintType(DataType t, std::ostream& os) { // NOLINT(*)
Expand Down
1 change: 1 addition & 0 deletions src/target/source/codegen_metal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class CodeGenMetal final : public CodeGenC {

private:
int thread_index_bits_{32};
int thread_work_dim_{0};
Target target_;
};
} // namespace codegen
Expand Down