[Bugfix][VTA] Fix FSIM compile error on macOS#14655
Merged
tqchen merged 4 commits intoapache:mainfrom Nov 6, 2023
Merged
Conversation
VTA FSIM could not be built on macOS, for it leverages malloc.h and memalign, yet both have been deprecated and are not provided by macOS. This issue was captured in apache#13173. This commit stops including malloc.h in VTA Runtime as stdlib.h has provided functions we need. This commit uses posix_memalign instead of memalign. It is a portable standard function.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
xhmelon
changed the title
Contributor
Author
|
@vegaluisjose @vinx13 @masahi Errors from gpu/pr-head and lint/pr-head have prevented merging. The gpu/pr-head failed to pull the git repo, and I can not rerun the @tvm-bot myself. Meanwhile, I couldn't find out what's wrong with lint/pr-head from the log, could you give any insight? |
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
@liangfu Please review this PR. |
Contributor
Author
|
@liangfu @vegaluisjose It seems that merging the PR requires your permission, right? All tests passed, but there is still a prompt "1 workflow awaiting approval". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTA FSIM could not be built on macOS, for it leverages malloc.h and memalign, yet both have been deprecated and are not provided by macOS. This issue was captured in #13173.
This commit stops including malloc.h in VTA Runtime as stdlib.h has provided functions we need.
This commit uses posix_memalign instead of memalign. It is a portable standard function.
cc @vegaluisjose @liangfu