[CI] Downgrade ci_cpu llvm version back to 11#14680
Merged
leandron merged 1 commit intoapache:mainfrom Apr 20, 2023
Merged
Conversation
The upgrade to llvm 15 caused failures in topi tests python/topi/python/test_topi_math.py::test_cast[float64-float16-llvm]. It seems to be a miscompilation due to opaque pointers. Downgrading while working to fix the issue.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Contributor
|
@tvm-bot rerun |
Member
|
@neildhickey thanks for the investigation! I saw this issue in my ci upgrade work (#14651), it would better to fix this cast issue, looks the cast from f64 to f16 generates wrong result. |
Contributor
Author
|
@yongwww Yes I do want to fix the issue properly but put up this patch as a temporary work around until I am able to fix it properly |
leandron
approved these changes
Apr 20, 2023
Contributor
leandron
left a comment
There was a problem hiding this comment.
Thanks for looking into it @neildhickey
Contributor
|
Merging this to make the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade to llvm 15 caused failures in topi tests python/topi/python/test_topi_math.py::test_cast[float64-float16-llvm]. It seems to be a miscompilation due to opaque pointers. Downgrading while working to fix the issue.