[CMAKE] Update search pattern of config#14686
Merged
leandron merged 1 commit intoapache:mainfrom Apr 21, 2023
Merged
Conversation
This PR updates the search patter of config.cmake to CMAKE_BINARY_DIR. This behavior remains unchanged for TVM build. The difference only happens when tvm was included as a subdirectory by another project via add_subdirectory. In such cases, we will search the config.cmake on the root of the parent project rather than the tvm folder.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Member
Author
|
cc @junrushao |
junrushao
approved these changes
Apr 21, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
That makes sense! Thanks for the change!
leandron
approved these changes
Apr 21, 2023
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, thanks @tqchen @junrushao
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Apr 21, 2023
This PR updates the search patter of config.cmake to CMAKE_BINARY_DIR. This behavior remains unchanged for TVM build. The difference only happens when tvm was included as a subdirectory by another project via add_subdirectory. In such cases, we will search the config.cmake on the root of the parent project rather than the tvm folder.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Apr 26, 2023
This PR updates the search patter of config.cmake to CMAKE_BINARY_DIR. This behavior remains unchanged for TVM build. The difference only happens when tvm was included as a subdirectory by another project via add_subdirectory. In such cases, we will search the config.cmake on the root of the parent project rather than the tvm folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the search patter of config.cmake to CMAKE_BINARY_DIR. This behavior remains unchanged for TVM build.
The difference only happens when tvm was included as a subdirectory by another project via add_subdirectory.
In such cases, we will search the config.cmake on the root of the parent project rather than the tvm folder.