[TIR] Enhance TVMScript Buffer Slice Access#14693
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
cc @cyx-6 |
junrushao
left a comment
There was a problem hiding this comment.
I don't have problem with the fix per se, but was thinking if this ad-hoc fix is sufficient. To be more precise, vectorized buffer access being recognized as PrimExpr instead of BufferRegion.
|
Thanks @lightzhan-intellif for the fix! I think it would be good to also test that the scripted output of |
Thanks for your suggestion, I will have a look. |
This PR tries to fix a bug, which will case the error:
The problem will occur when it is a binary operation between two BufferSlice accesses, because the parser do not know how to deal with it.
This PR solves this by adding corresponding ops to
BufferRegion. Any further suggestion is welcomed!@junrushao @Hzfengsy @wrongtest-intellif