Skip to content

unify search path approach to various libs#14694

Merged
tqchen merged 1 commit intoapache:mainfrom
t-vi:findcuda
Apr 22, 2023
Merged

unify search path approach to various libs#14694
tqchen merged 1 commit intoapache:mainfrom
t-vi:findcuda

Conversation

@t-vi
Copy link
Copy Markdown
Contributor

@t-vi t-vi commented Apr 21, 2023

The FindCUDA looks for the various libraries in a more or less limited set of locations.
For nvrtc we currently have the most complete search, the others are lacking one or more locations.
This makes FindCUDA look in all typical linux lib dirs (e.g. Debian's CUDA install wants that).

Thank you for considering.

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Apr 21, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to auto-tag found, no teams are specified in PR title See #10317 for details

Generated by tvm-bot

@t-vi
Copy link
Copy Markdown
Contributor Author

t-vi commented Apr 21, 2023

@junrushao I think you touched this last, and @tqchen before
If you have other suggestions for reviewers, I would also appriciate a hint.

@tqchen tqchen merged commit d27837a into apache:main Apr 22, 2023
@tqchen
Copy link
Copy Markdown
Member

tqchen commented Apr 22, 2023

Thank you @t-vi !

@t-vi
Copy link
Copy Markdown
Contributor Author

t-vi commented Apr 22, 2023

Thank you, @tqchen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants