[bugfix][relay] Fix alpha attribute with None in ELU #14742
Merged
echuraev merged 2 commits intoapache:mainfrom May 2, 2023
jikechao:fix_elu
Merged
[bugfix][relay] Fix alpha attribute with None in ELU #14742echuraev merged 2 commits intoapache:mainfrom jikechao:fix_elu
echuraev merged 2 commits intoapache:mainfrom
jikechao:fix_elu
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Member
Author
|
Hi @echuraev @AndrewZhaoLuo, could you help me review it? Thank you! |
echuraev
approved these changes
May 1, 2023
Contributor
echuraev
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your PR.
Member
Author
|
@tvm-bot rerun |
1 similar comment
Member
Author
|
@tvm-bot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug in ELU. when the alpha=None, It will lead to a wrong compilation and give a confusing inference result.
For example, the following script will produce inconsistent inference results between TVM and Keras. However, we hope tvm can reject it immediately in the model loading stage. Because the model is invalid (see Line 210-212 in keras source code file).
This PR is a similar fix to the pr-14707. pr-14707 fixed a similar bug in LeakyReLU.
Reproducible script