[bugfix][relay] fix wrong calculate logic about celu#14796
Merged
echuraev merged 4 commits intoapache:mainfrom May 8, 2023
jikechao:fix_celu
Merged
[bugfix][relay] fix wrong calculate logic about celu#14796echuraev merged 4 commits intoapache:mainfrom jikechao:fix_celu
echuraev merged 4 commits intoapache:mainfrom
jikechao:fix_celu
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Hzfengsy
approved these changes
May 8, 2023
echuraev
approved these changes
May 8, 2023
Contributor
echuraev
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculation formula of
CELUis wrong in relay/pytorch. This pr fix it.From the pytorch documentation, we can get the calculating logic of CELU.

Reproducible Script
script output
cc @AndrewZhaoLuo @echuraev