[TVMScript] Handle AllocatedPoolInfo, ConstantPoolInfo, ConstantInfo#14812
[TVMScript] Handle AllocatedPoolInfo, ConstantPoolInfo, ConstantInfo#14812junrushao merged 1 commit intoapache:mainfrom
Conversation
These objects may appear as part of a TIR PrimFunc following the `tir.usmp.ConvertPoolAllocationsToOffsets` transform. Prior to this commit, any such PrimFuncs would result in errors when printing TVMScript, along with a fallback to the legacy repr.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
| ) | ||
|
|
||
|
|
||
| @register_object("ir.ConstantMemoryPools") |
There was a problem hiding this comment.
A bit off the topic, but to some extent, I believe it might be less ideal if we expose those feature-dependent component in tvm/ir folder, which is supposed to be generic.
There was a problem hiding this comment.
Yeah, I wasn't sure how much refactoring to include in this PR. There were some clear inconsistencies, such as the wrong object name being in @register_object, but this feels like something that should be in the tir.usmp namespace.
There was a problem hiding this comment.
Agreed. This seems less organized. Let's leave this to future change
3 participants
These objects may appear as part of a TIR PrimFunc following the
tir.usmp.ConvertPoolAllocationsToOffsetstransform. Prior to this commit, any such PrimFuncs would result in errors when printing TVMScript, along with a fallback to the legacy repr.