[bugfix][Relay] Fix softplus in paddlepaddle frontend#14845
Merged
echuraev merged 3 commits intoapache:mainfrom May 15, 2023
jikechao:fix_softplus_paddle
Merged
[bugfix][Relay] Fix softplus in paddlepaddle frontend#14845echuraev merged 3 commits intoapache:mainfrom jikechao:fix_softplus_paddle
echuraev merged 3 commits intoapache:mainfrom
jikechao:fix_softplus_paddle
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed a similar bug with #14821 in the PaddlePaddle frontend.
For the PaddlePaddle documentation, when input * beta > threshold, Softplus(x) = x.
TVM miss this special case handling. It would cause wrong inference results.
A patch and a Test case that can trigger this bug are submitted in this PR.
cc @Hzfengsy @echuraev @jiangjiajun