[TVMScript] Use default fallback for un-registered type#14874
Merged
masahi merged 1 commit intoapache:mainfrom May 18, 2023
Merged
[TVMScript] Use default fallback for un-registered type#14874masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Previously, even if an object is supported by TVMScript, printing that object could fail if the object contains references to un-registered objects. In particular, the attributes in the `PrimFunc` and `AttrStmt` may contain any `ObjectRef`, and are frequently used for external bookkeeping. This commit adds a default printer for unregistered types in TVMScript.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
May 17, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks a lot for this change!! Instead of a direct crash, this approach provides a nice and readable safety net for all un-registered types!
junrushao
approved these changes
May 17, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks a lot for this change!! Instead of a direct crash, this approach provides a nice and readable safety net for all un-registered types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, even if an object is supported by TVMScript, printing that object could fail if the object contains references to un-registered objects. In particular, the attributes in the
PrimFuncandAttrStmtmay contain anyObjectRef, and are frequently used for external bookkeeping. This commit adds a default printer for unregistered types in TVMScript.This is a follow-up to changes made in #14840