Skip to content

[TypoFix] fix some typo problem in keras frontend#14916

Merged
echuraev merged 2 commits intoapache:mainfrom
jikechao:fix_crash_message
May 23, 2023
Merged

[TypoFix] fix some typo problem in keras frontend#14916
echuraev merged 2 commits intoapache:mainfrom
jikechao:fix_crash_message

Conversation

@jikechao
Copy link
Copy Markdown
Member

@jikechao jikechao commented May 22, 2023

This pr fixed a typo problem which could give an ambiguous crash message.

@echuraev @merrymercy @masahi

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented May 22, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: typofix See #10317 for details

Generated by tvm-bot

@jikechao jikechao changed the title [TypoFix] fix a wrong crash message at keras frontend [TypoFix] fix a wrong crash message in keras frontend May 22, 2023
@jikechao jikechao changed the title [TypoFix] fix a wrong crash message in keras frontend [TypoFix] fix some wrong crash message in keras frontend May 22, 2023
@jikechao jikechao changed the title [TypoFix] fix some wrong crash message in keras frontend [TypoFix] fix some typo problem in keras frontend May 22, 2023
Copy link
Copy Markdown
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@echuraev echuraev merged commit 4f99750 into apache:main May 23, 2023
mei-ye pushed a commit to mei-ye/tvm that referenced this pull request Jun 1, 2023
* fix a wrong crash message

* Update keras.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants