[AOT] Remove duplication in tvm.testing.aot.compile_models#15032
Merged
lhutton1 merged 1 commit intoapache:mainfrom Jun 13, 2023
Merged
[AOT] Remove duplication in tvm.testing.aot.compile_models#15032lhutton1 merged 1 commit intoapache:mainfrom
lhutton1 merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Previously, the body of an if/else were nearly identical, except for a `with apply_fixed_config` context. This commit removes the duplication using `contextlib.ExitStack` to conditionally enter the context.
Lunderberg
force-pushed
the
aot_build_deduplicate
branch
from
61f7d10 to
23113a5
Compare
lhutton1
approved these changes
Jun 12, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the simplification @Lunderberg!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the body of an if/else were nearly identical, except for a
with apply_fixed_configcontext. This commit removes the duplication usingcontextlib.ExitStackto conditionally enter the context.