[TIR] Handle DeclBuffer in CacheReadWrite schedule primitive#15037
[TIR] Handle DeclBuffer in CacheReadWrite schedule primitive#15037vinx13 merged 2 commits intoapache:mainfrom
Conversation
Part of changes being split out from apache#14778 into independent portions. This commit allows TIR `cache_read` and `cache_write` schedule primitives to preserve `DeclBuffer` nodes.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
@Lunderberg there seems to be a regression introduced by this PR |
|
see https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-minimal-cross-isa/detail/nightly/140/pipeline/84 |
|
Not sure if it is a failed or flaky test, it is something that appears in this PR, and some followup commits. Perhaps some recent changes introduces some non-determinsm? |
|
Thank you, and I can reproduce that failure. It does seem to be a flaky test, with 28 failures out of 100 repetitions on main. Though, on bisecting, it looks like the flaky failures were introduced in 02dc191 (#15081). The previous commit, 68ac909 (#15073), is able to pass the test 100/100 times, while #15081 shows about the same 30% failure rate. |
|
I have a quick bugfix PR at #15128, which should resolve the flaky test. I didn't tracked down why that specific overwrite results in failure to recognize a stage pipeline, but that does resolve the specific failure mode. |
Part of changes being split out from #14778 into independent portions. This commit allows TIR
cache_readandcache_writeschedule primitives to preserveDeclBuffernodes.