[Bugfix][Relay][Keras] Fix UpSampling2D about the wrong assertion about size#15082
Merged
echuraev merged 3 commits intoapache:mainfrom Jun 14, 2023
jikechao:fix_unsample_assert
Merged
[Bugfix][Relay][Keras] Fix UpSampling2D about the wrong assertion about size#15082echuraev merged 3 commits intoapache:mainfrom jikechao:fix_unsample_assert
echuraev merged 3 commits intoapache:mainfrom
jikechao:fix_unsample_assert
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Hzfengsy
approved these changes
Jun 13, 2023
echuraev
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed the wrong assertion about UpSampling2D.
In the Keras frontend of TVM, The UpSampling2D has a wired constraint: "Height must equal width for operator Upsample."
However, from the documentation about UpSampling2D, The constraint about
.
sizeis, " Int, or tuple of 2 integers". Meanwhile, An official example from the Keras documentation uses the size(1, 2)Thus, the assertion in TVM is wrong. I deleted the related statements and added a bug-triggering test case.
@echuraev @masahi @Hzfengsy