Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/tir/transforms/lower_device_storage_access_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ class StorageAccessInfoLower : public StmtExprMutator {
}
}

Stmt VisitStmt_(const DeclBufferNode* op) final {
auto node = Downcast<DeclBuffer>(StmtExprMutator::VisitStmt_(op));
if (auto it = storage_info_.find(node->buffer->data.get());
it != storage_info_.end() && !it->second->head_address.defined()) {
return node->body;
} else {
return std::move(node);
}
}

PrimExpr VisitExpr_(const CallNode* op) final {
if (op->op.same_as(builtin::tvm_access_ptr())) {
return MakeAccessPtr(op);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

import tvm
from tvm.script import tir as T


@tvm.register_func("tvm.info.mem.global.test_with_head_address")
def mem_info_with_head_address():
return tvm.ir.make_node(
"MemoryInfo",
unit_bits=8,
max_simd_bits=32,
max_num_bits=128,
head_address=tvm.tir.call_extern("handle", "dummy_head_address"),
)


@tvm.register_func("tvm.info.mem.global.test_without_head_address")
def mem_info_without_head_address():
return tvm.ir.make_node(
"MemoryInfo",
unit_bits=8,
max_simd_bits=32,
max_num_bits=128,
head_address=None,
)


class BaseCompare(tvm.testing.CompareBeforeAfter):
transform = tvm.tir.transform.LowerDeviceStorageAccessInfo()


class TestLowerCPUAccessibleScope(BaseCompare):
"""Allocate of CPU-visible buffers are replaced by LetStmt

For scopes that are accessible by the CPU (e.g. VTCM on hexagon),
the head address specifies how it should be accessed, and is used
to replace the AllocateNode.
"""

def before():
ptr = T.allocate([16], "float32", scope="global.test_with_head_address")
T.evaluate(ptr)

def expected():
ptr: T.handle("float32", "global.test_with_head_address") = T.call_extern( # noqa: F722
"handle", "dummy_head_address"
)
T.evaluate(ptr)


class TestLowerCPUAccessibleScopeWithDeclBuffer(BaseCompare):
"""Like TestLowerCPUAccessibleScope, but with a DeclBuffer.

When the Allocate is updated, the DeclBuffer should not contain a
dangling reference.
"""

def before():
buf = T.decl_buffer(16, "float32", scope="global.test_with_head_address")
T.evaluate(buf.data)

def expected():
ptr: T.handle("float32", "global.test_with_head_address") = T.call_extern( # noqa: F722
"handle", "dummy_head_address"
)
buf = T.decl_buffer(16, "float32", scope="global.test_with_head_address", data=ptr)
T.evaluate(ptr)


class TestLowerCPUInaccessibleScope(BaseCompare):
"""Allocate of CPU-visible buffers are replaced by LetStmt

For scopes that are inaccessible by the CPU (e.g. Texture memory
on GPU), the allocate is removed. All CPU-side references to the
buffer should have been lowered by this point.
"""

def before():
ptr = T.allocate([16], "float32", scope="global.test_without_head_address")
T.evaluate(0)

def expected():
T.evaluate(0)


class TestLowerCPUInaccessibleScopeWithDeclBuffer(BaseCompare):
"""Like TestLowerCPUInaccessibleScope, but with a DeclBuffer

When the Allocate is removed, the DeclBuffer should not contain a
dangling reference.
"""

def before():
buf = T.decl_buffer(16, "float32", scope="global.test_without_head_address")
T.evaluate(0)

def expected():
T.evaluate(0)


if __name__ == "__main__":
tvm.testing.main()