[TIR] Handle DeclBuffer in MergeDynamicSharedMemoryAllocations#15094
Merged
vinx13 merged 2 commits intoapache:mainfrom Jun 16, 2023
Merged
[TIR] Handle DeclBuffer in MergeDynamicSharedMemoryAllocations#15094vinx13 merged 2 commits intoapache:mainfrom
vinx13 merged 2 commits intoapache:mainfrom
Conversation
Preserve DeclBuffer node when transforming with `MergeDynamicSharedMemoryAllocations`. Any `DeclBuffer` nodes that refer to merged allocations nodes are updated to refer to the merged allocation. This is a subset of changes, being split out from apache#14778 into independent portions.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Some of the unit tests passed a Allocate/DeclBuffer whose different shapes, due to alignment restrictions. Moved the stripping of DeclBuffer that occurs in FlattenBuffer to a dedicated visitor, rather than occurring as part of the Allocate visitor.
Lunderberg
force-pushed
the
declbuffer_merge_dynamic_shared_alloc
branch
from
5e4a095 to
ebfc007
Compare
vinx13
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve DeclBuffer node when transforming with
MergeDynamicSharedMemoryAllocations. AnyDeclBuffernodes that refer to merged allocations nodes are updated to refer to the merged allocation. This is a subset of changes, being split out from #14778 into independent portions.