[LLVM] Remove the "ret_void" argument of AddFunction#15127
Merged
tqchen merged 1 commit intoapache:mainfrom Jun 23, 2023
Merged
[LLVM] Remove the "ret_void" argument of AddFunction#15127tqchen merged 1 commit intoapache:mainfrom
tqchen merged 1 commit intoapache:mainfrom
Conversation
Prior to this commit, the `"ret_void"` argument needed to be explicitly provided to `CodeGenLLVM::AddFunction` and `CodeGenLLVM::DeclareFunction`. If this was inconsistent with the `builtin::ret()` usage within the `PrimFunc`, this could cause the incorrect return type in the generated LLVM-IR, resulting in LLVM IR verification failures. This commit removes the `"ret_void"` argument, instead using the type annotation in `PrimFunc::ret_type`, removing this opportunity for inconsistency. This PR is intended to fix a ROCm regression reported in apache#14901 (comment).
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Lunderberg
changed the title
Lunderberg
changed the title
tqchen
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
"ret_void"argument needed to be explicitly provided toCodeGenLLVM::AddFunctionandCodeGenLLVM::DeclareFunction. If this was inconsistent with thebuiltin::ret()usage within thePrimFunc, this could cause the incorrect return type in the generated LLVM-IR, resulting in LLVM IR verification failures.This commit removes the
"ret_void"argument, instead using the type annotation inPrimFunc::ret_type, removing this opportunity for inconsistency.This PR is intended to fix a ROCm regression reported in #14901 (comment).