Skip to content

[TIR][Schedule] Support padding-by-factor in PadEinsum#15168

Merged
spectrometerHBH merged 1 commit intoapache:mainfrom
junrushao:feature/2023-06-26/enhance-pad-einsum
Jun 28, 2023
Merged

[TIR][Schedule] Support padding-by-factor in PadEinsum#15168
spectrometerHBH merged 1 commit intoapache:mainfrom
junrushao:feature/2023-06-26/enhance-pad-einsum

Conversation

@junrushao
Copy link
Copy Markdown
Member

This PR introduces a minor behavior change in Pad-Einsum that makes it support padding-by-factor instead of padding-by-constant-number.

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Jun 27, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@junrushao junrushao marked this pull request as ready for review June 27, 2023 06:00
@junrushao junrushao force-pushed the feature/2023-06-26/enhance-pad-einsum branch from 49761ed to aba2ff0 Compare June 27, 2023 14:38
Copy link
Copy Markdown
Member

@vinx13 vinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/tir/schedule/primitive.h Outdated
@junrushao junrushao force-pushed the feature/2023-06-26/enhance-pad-einsum branch 3 times, most recently from f745619 to fd1bb61 Compare June 27, 2023 23:33
@junrushao
Copy link
Copy Markdown
Member Author

Thanks @vinx13 for the huge help fixing the tensor core case!

@junrushao junrushao force-pushed the feature/2023-06-26/enhance-pad-einsum branch from d78a377 to 774dc8c Compare June 28, 2023 03:37
@junrushao
Copy link
Copy Markdown
Member Author

Fixed a merge conflict

This PR introduces a minor behavior change in Pad-Einsum that makes it
support padding-by-factor instead of padding-by-constant-number.

Co-authored-by: Wuwei Lin <wuwei@apache.org>
@junrushao junrushao force-pushed the feature/2023-06-26/enhance-pad-einsum branch from 774dc8c to ea715ef Compare June 28, 2023 05:15
@spectrometerHBH spectrometerHBH merged commit 99d72fd into apache:main Jun 28, 2023
nox-410 pushed a commit to nox-410/tvm that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants