Skip to content

Update tvm_runtime.h#15185

Merged
tqchen merged 2 commits intoapache:mainfrom
DengZH1214:main
Jul 2, 2023
Merged

Update tvm_runtime.h#15185
tqchen merged 2 commits intoapache:mainfrom
DengZH1214:main

Conversation

@DengZH1214
Copy link
Copy Markdown
Contributor

lack of include

lack of include
@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Jun 30, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to auto-tag found, no teams are specified in PR title See #10317 for details

Generated by tvm-bot

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Jun 30, 2023

please fix the lint error. thank you @DengZH1214

@junrushao
Copy link
Copy Markdown
Member

The linter error is:

[2023-06-30T07:50:08.607Z]  #ifdef TVM_VULKAN_RUNTIME
[2023-06-30T07:50:08.607Z] +#include "../src/runtime/vulkan/vulkan_amdrgp.cc"
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_buffer.cc"
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_common.cc"
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_device.cc"
[2023-06-30T07:50:08.607Z] @@ -78,7 +79,6 @@
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_module.cc"
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_stream.cc"
[2023-06-30T07:50:08.607Z]  #include "../src/runtime/vulkan/vulkan_wrapped_func.cc"
[2023-06-30T07:50:08.607Z] -#include "../src/runtime/vulkan/vulkan_amdrgp.cc"
[2023-06-30T07:50:08.607Z]  #endif

which means you might want to swap the ordering of "#include"s

@tqchen tqchen merged commit 977b4b2 into apache:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants