Skip to content

[TIR][Schedule] Scoped CacheRead/Write producing compact region #15236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
Jul 6, 2023
Merged

[TIR][Schedule] Scoped CacheRead/Write producing compact region #15236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tir/schedule/primitive.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ TVM_DLL std::vector<int64_t> SamplePerfectTile(
* The sampled tile size will be partitioned into two parts. The second part has a guarantee
* that their extent's product have a factor of `innerpart_factor`. The first part is loops at
* [0, partition_pos); the second part is loops at [partition_pos, n) and we will have
* `innerpart_factor` | \prod_{l=partition_pos}^{n-1} l.extent
* `innerpart_factor` | prod_{l=partition_pos}^{n-1} l.extent
Copy link
Copy Markdown
Contributor Author

@MasterJH5574 MasterJH5574 Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this since Clang will warn

1 warning generated.
In file included from /home/ruihangl/tvm/src/tir/schedule/primitive/for_kind.cc:19:
In file included from /home/ruihangl/tvm/src/tir/schedule/primitive/../utils.h:49:
/home/ruihangl/tvm/src/tir/schedule/primitive/.././primitive.h:108:26: warning: unknown command tag name [-Wdocumentation-unknown-command]
 *  `innerpart_factor` | \prod_{l=partition_pos}^{n-1} l.extent
                         ^~~~~~

*
* \param rand_state The random state
* \param extent The loop extent to be tiled
Expand All @@ -123,7 +123,7 @@ TVM_DLL std::vector<int64_t> SamplePartitionedTile(
* The sampled tile size will be partitioned into two parts. The second part has a guarantee
* that their extent's product have a factor of `innerpart_factor`. The first part is loops at
* [0, partition_pos); the second part is loops at [partition_pos, n) and we will have
* `innerpart_factor` | \prod_{l=partition_pos}^{n-1} l.extent
* `innerpart_factor` | prod_{l=partition_pos}^{n-1} l.extent
*
* \param rand_state The random state
* \param loop_sref The loop to be tiled
Expand Down
Loading