[TVMScript] Ensure completed root block has no read/write#15249
Merged
tqchen merged 1 commit intoapache:mainfrom Jul 7, 2023
Merged
[TVMScript] Ensure completed root block has no read/write#15249tqchen merged 1 commit intoapache:mainfrom
tqchen merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Jul 6, 2023
MasterJH5574
force-pushed
the
tvm-dev/2023-07-05-complete-read-write
branch
from
f271dcf to
358620b
Compare
Prior to this PR, the root block of a parsed TIR TVMScript is possible to have non-empty read/write regions, which conflicts with the design of root blocks in TIR. This PR updates the script completion pass and ensures that the root block will no longer have read/write region.
MasterJH5574
force-pushed
the
tvm-dev/2023-07-05-complete-read-write
branch
from
358620b to
cf827d2
Compare
Hzfengsy
approved these changes
Jul 7, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 15, 2023
Prior to this PR, the root block of a parsed TIR TVMScript is possible to have non-empty read/write regions, which conflicts with the design of root blocks in TIR. This PR updates the script completion pass and ensures that the root block will no longer have read/write region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the root block of a parsed TIR TVMScript is possible to have non-empty read/write regions, which conflicts with the design of root blocks in TIR.
This PR updates the script completion pass and ensures that the root block will no longer have read/write region.