[Hexagon] Propagate QNN Concat Quantization Params to Inputs#15258
Merged
quic-sanirudh merged 4 commits intoapache:mainfrom Jul 10, 2023
Merged
[Hexagon] Propagate QNN Concat Quantization Params to Inputs#15258quic-sanirudh merged 4 commits intoapache:mainfrom
quic-sanirudh merged 4 commits intoapache:mainfrom
Conversation
…ting redundant requantization when possible, and make it concat
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
66eecf8 to
faf5854
Compare
quic-sanirudh
approved these changes
Jul 7, 2023
Contributor
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM apart from a minor comment.
Contributor
|
@tvm-bot rerun |
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
…15258) * [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat * Fix pylint issue * Add relay IR snippet before and after transformation * Better test file description comment
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
…15258) * [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat * Fix pylint issue * Add relay IR snippet before and after transformation * Better test file description comment
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
…15258) * [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat * Fix pylint issue * Add relay IR snippet before and after transformation * Better test file description comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps in using optimized implementations of concat; this PR also avoids redundant requantization when an input to a concat is already a requantize op.