[RPC] Fix socket bind errno on corner case#15292
Merged
Hzfengsy merged 1 commit intoapache:mainfrom Jul 12, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Jul 12, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
fix socket bind errno on corner case
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
fix socket bind errno on corner case
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
fix socket bind errno on corner case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
LOG(WARNING)may invoke system calls, the errno of socket bind failure is overwrite, which makeTryBindPortexit without any more trials. The errno check should be put just afterbindreturn.Here is an example from strace,
The stacktrace would be (errno became to be ENOENT):