[OP] Add rms_norm into TOPI#15326
Merged
junrushao merged 3 commits intoapache:mainfrom Jul 18, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
reviewed
Jul 15, 2023
sunggg
reviewed
Jul 17, 2023
Contributor
sunggg
left a comment
sunggg
left a comment
There was a problem hiding this comment.
Thank you for the nice work! A few minor comments.
|
|
||
| # only test on llvm because schedule is missing | ||
| @tvm.testing.parametrize_targets("llvm") | ||
| @pytest.mark.parametrize("shape,axis", [([4, 16], (1,)), ([4, 16, 16], (1, 2))]) |
Contributor
There was a problem hiding this comment.
If it also support symbolic shape, would you add a testcase?
Contributor
Author
There was a problem hiding this comment.
yes, the symbolic shape test has been added.
| << "rms_norm: only support float32 and float16 for now"; | ||
| bool is_float16 = data_type == DataType::Float(16); | ||
|
|
||
| auto x = is_float16 ? cast(data, DataType::Float(32)) : data; |
Contributor
There was a problem hiding this comment.
Why do we need casting here?
Contributor
Author
There was a problem hiding this comment.
Actually no, and all the cast have been removed.
This PR introduces the operator root mean square, `rms_norm`, into TOPI.
MasterJH5574
approved these changes
Jul 17, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
This PR introduces the operator root mean square, `rms_norm`, into TOPI.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
This PR introduces the operator root mean square, `rms_norm`, into TOPI.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
This PR introduces the operator root mean square, `rms_norm`, into TOPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the operator root mean square,
rms_norm, into TOPI.