[Bugfix][Frontend][Keras]Fix a corner case bug in softmax converter of keras frontend#15337
Merged
echuraev merged 3 commits intoapache:mainfrom Jul 18, 2023
jikechao:fix_softmax_none
Merged
[Bugfix][Frontend][Keras]Fix a corner case bug in softmax converter of keras frontend#15337echuraev merged 3 commits intoapache:mainfrom jikechao:fix_softmax_none
echuraev merged 3 commits intoapache:mainfrom
jikechao:fix_softmax_none
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Jul 17, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
…f keras frontend (apache#15337) * Fix softmax converter about keras * add new test cases to capture the bug * Update keras.py
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
…f keras frontend (apache#15337) * Fix softmax converter about keras * add new test cases to capture the bug * Update keras.py
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
…f keras frontend (apache#15337) * Fix softmax converter about keras * add new test cases to capture the bug * Update keras.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a corner bug in the softmax converter in the Keras frontend.
If the input dimension of softmax is 1, TVM will crash unexpectedly.
StackTrace
Steps to reproduce
cc @echuraev @Hzfengsy @leandron