[TVMC] Add tvmc flag to print compilation time per pass#15349
Merged
lhutton1 merged 3 commits intoapache:mainfrom Jul 25, 2023
Merged
[TVMC] Add tvmc flag to print compilation time per pass#15349lhutton1 merged 3 commits intoapache:mainfrom
lhutton1 merged 3 commits intoapache:mainfrom
Conversation
Added a new flag `--print-pass-times` for tvmc compile to provide debugging information for tvmc users using `PassTimingInstrument`. Also added a test to check the printing of timing results.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
lhutton1
reviewed
Jul 19, 2023
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @Anndrey24, I think this will be a really useful feature for debugging compilation performance issues! The patch looks great, I just had some small questions/comments below. If possible could you add a small example of the output to the PR description?
Moved patch functionality inside `compile_model` to allow printing pass times from both TVMC Python API and command line API. Changed test to search for timing-specific keywords.
lhutton1
approved these changes
Jul 25, 2023
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @Anndrey24, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new flag
--print-pass-timesfor tvmc compile to provide debugging information for tvmc users usingPassTimingInstrument.Also added a test to check the printing of timing results.
Example output: