[Codegen][Metal] Support metal warp-level primitive#15401
Merged
echuraev merged 1 commit intoapache:mainfrom Jul 26, 2023
Merged
[Codegen][Metal] Support metal warp-level primitive#15401echuraev merged 1 commit intoapache:mainfrom
echuraev merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Contributor
Author
|
|
This PR introduces the warp-level shuffle primitives used in Metal Shading Language, and uses them in the implementation of allreduce lowering. The introduced primitives are: * `simd_shuffle`, * `simd_shuffle_up`, * `simd_shuffle_down`. See section 6.9.2 of https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf for details. The correctness are validated by `test_allreduce_cuda` with the backend changed to Metal. Given we do not have Metal CI tests, the correctness is checked only locally. Given the Metal shuffle primitives do not support (or need) masking, the pass LowerThreadAllreduce is updated to support such backend which does not have masks. One unit test for metal is added to ensure that no mask is used.
MasterJH5574
force-pushed
the
tvm-dev/2023-07-25-metal-warp-level
branch
from
7b1a687 to
fb416ef
Compare
tqchen
approved these changes
Jul 26, 2023
echuraev
approved these changes
Jul 26, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the warp-level shuffle primitives used in Metal Shading Language, and uses them in the implementation of allreduce lowering.
The introduced primitives are:
simd_shuffle,simd_shuffle_up,simd_shuffle_down.See section 6.9.2 of https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf for details.
The correctness are validated by
test_allreduce_cudawith the backend changed to Metal. Given we do not have Metal CI tests, the correctness is checked only locally.Given the Metal shuffle primitives do not support (or need) masking, the pass LowerThreadAllreduce is updated to support such backend which does not have masks. One unit test for metal is added to ensure that no mask is used.