[TIR] Fix Primitive Rfactor DType#15413
Merged
MasterJH5574 merged 1 commit intoapache:mainfrom Jul 26, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
The rfactor primitive will create/rewrite two blocks, together with the block read/write regions. However, the generated read/write region extents are not valid when it's a int64 index. This commit fixes the issue.
MasterJH5574
approved these changes
Jul 26, 2023
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thanks! dtype is indeed something we didn't pay attention to when wrote these schedule primitives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rfactor primitive will create/rewrite two blocks, together with the block read/write regions. However, the generated read/write region extents are invalid when it's an int64 index. This commit fixes the issue.
cc @MasterJH5574