Skip to content

[Runtime] Enhance PackedFunc Metaprogramming with PackArgs #15595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyx-6 merged 1 commit into from
Aug 20, 2023
Merged

[Runtime] Enhance PackedFunc Metaprogramming with PackArgs #15595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions include/tvm/runtime/packed_func.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,13 +1284,27 @@ namespace parameter_pack {

template <typename... EnumArgs>
struct EnumeratedParamPack {
struct Invoke {
template <template <size_t i, typename TArgument> class Functor, typename... ExtraParams>
static void F(ExtraParams&&... extra_params) {
struct InvokeWithoutArg {
template <template <size_t i, typename TArgument> class Functor, typename ExtraParams>
static void F(ExtraParams&& extra_params) {
using TExpander = int[];
(void)TExpander{
0,
(Functor<EnumArgs::i, typename EnumArgs::T>::F(extra_params...), 0)...,
(Functor<EnumArgs::i, typename EnumArgs::T>::F(std::forward<ExtraParams>(extra_params)),
0)...,
};
}
};
struct InvokeWithArg {
template <template <size_t i, typename TArgument> class Functor, typename ExtraParams,
typename... Params>
static void F(ExtraParams&& extra_params, Params&&... params) {
using TExpander = int[];
(void)TExpander{
0,
(Functor<EnumArgs::i, typename EnumArgs::T>::F(std::forward<ExtraParams>(extra_params),
std::forward<Params>(params)),
0)...,
};
}
};
Expand All @@ -1310,22 +1324,27 @@ struct EnumerateImpl {

template <std::size_t... id>
struct Zipper<std::integer_sequence<std::size_t, id...>> {
using T = EnumeratedParamPack<Item<id, Args>...>;
using WithoutArg = typename EnumeratedParamPack<Item<id, Args>...>::InvokeWithoutArg;
using WithArg = typename EnumeratedParamPack<Item<id, Args>...>::InvokeWithArg;
};

public:
using T = typename Zipper<std::index_sequence_for<Args...>>::T;
using WithoutArg = typename Zipper<std::index_sequence_for<Args...>>::WithoutArg;
using WithArg = typename Zipper<std::index_sequence_for<Args...>>::WithArg;
};

template <typename... Args>
using Enumerate = typename EnumerateImpl<Args...>::T;
using EnumerateWithoutArg = typename EnumerateImpl<Args...>::WithoutArg;

template <typename... Args>
using EnumerateWithArg = typename EnumerateImpl<Args...>::WithArg;

template <typename... Args>
struct ParamPack {
template <template <size_t i, typename TArgument> class Functor, typename... ExtraParams>
static void InvokeWithoutArg(ExtraParams&&... extra_params) {
Enumerate<Args...>::Invoke::template F<Functor, ExtraParams...>(
std::forward<ExtraParams>(extra_params)...);
template <template <size_t i, typename TArgument> class Functor, typename ExtraParams>
static void InvokeWithoutArg(ExtraParams&& extra_params) {
EnumerateWithoutArg<Args...>::template F<Functor, ExtraParams>(
std::forward<ExtraParams>(extra_params));
}
};

Expand Down Expand Up @@ -1622,6 +1641,20 @@ inline TVMRetValue PackedFunc::operator()(Args&&... args) const {
return rv;
}

template <int i, typename T>
Comment thread
kparzysz-quic marked this conversation as resolved.
struct TVMArgsSetterApply {
static TVM_ALWAYS_INLINE void F(TVMArgsSetter* setter, T&& value) {
(*setter)(i, std::forward<T>(value));
}
};

template <typename... Args>
void TVM_ALWAYS_INLINE PackArgs(TVMValue* values, int* type_codes, Args&&... args) {
TVMArgsSetter setter(values, type_codes);
detail::parameter_pack::EnumerateWithArg<Args...>::template F<TVMArgsSetterApply>(
&setter, std::forward<Args>(args)...);
}

namespace detail {
template <typename R, int nleft, int index, typename F>
struct unpack_call_dispatcher {
Expand Down