[Relay][Bugfix] Fix the wrong implementation about operator Threshold in oneflow#15715
Merged
echuraev merged 6 commits intoapache:mainfrom Sep 12, 2023
jikechao:fix_threshold_oneflow
Merged
[Relay][Bugfix] Fix the wrong implementation about operator Threshold in oneflow#15715echuraev merged 6 commits intoapache:mainfrom jikechao:fix_threshold_oneflow
echuraev merged 6 commits intoapache:mainfrom
jikechao:fix_threshold_oneflow
Conversation
Hzfengsy
approved these changes
Sep 9, 2023
cbalint13
requested changes
Sep 9, 2023
echuraev
approved these changes
Sep 11, 2023
cbalint13
approved these changes
Sep 11, 2023
add version checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation logic of Threshold in oneflow is as follows:
The detail information can be found here
This PR corrects the implementation and adds a corresponding test case.
cc @Hzfengsy @echuraev @vvchernov