[UnitTest][Metal] Parametrize allreduce GPU tests#15749
Merged
Hzfengsy merged 2 commits intoapache:mainfrom Sep 15, 2023
Merged
[UnitTest][Metal] Parametrize allreduce GPU tests#15749Hzfengsy merged 2 commits intoapache:mainfrom
Hzfengsy merged 2 commits intoapache:mainfrom
Conversation
As a first step to addressing the Metal codegen errors that required the reversion in apache#15725, parametrizing the unit tests for `allreduce`. While these tests are parametrized with `@tvm.testing.parametrize_targets("cuda", "metal")`, the automatic `tvm.testing.requires_metal` marker inserted for the metal parametrization will cause them to be skipped if the metal runtime is unavailable, which includes the current CI.
Contributor
Author
MasterJH5574
approved these changes
Sep 14, 2023
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thank you @Lunderberg.
Contributor
Author
|
Absolutely, @MasterJH5574. I'd like to get the Metal backend to have at least one CI test of lowering/execution, for testing prior to re-applying the Can you verify that the parametrized tests in this PR pass in your environment (pytest command below)? My dev machine runs Linux, and so all the Metal tests are skipped. TVM_TEST_TARGETS="metal" python3 -mpytest -v tests/python/unittest/test_allreduce.py |
Contributor
|
@Lunderberg Yes I can confirm that the test now skips CUDA and passes all Metal tests on mac. |
Contributor
Author
|
Thank you for the confirmation, and I'm now starting #15756 to enable testing in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step to addressing the Metal codegen errors that required the reversion in #15725, parametrizing the unit tests for
allreduce. While these tests are parametrized with@tvm.testing.parametrize_targets("cuda", "metal"), the automatictvm.testing.requires_metalmarker inserted for the metal parametrization will cause them to be skipped if the metal runtime is unavailable, which includes the current CI.