[CLI TOOLS][RTVM] Improve rtvm tool with new options to measure native performance#15818
Merged
srkreddy1238 merged 3 commits intoapache:mainfrom Sep 29, 2023
Merged
Conversation
Few fixes and enhancements that affects model loading times New options to measure performance.
srkreddy1238
changed the title
echuraev
reviewed
Sep 28, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Thank you for your PR! Just a couple of small comments
echuraev
reviewed
Sep 28, 2023
Contributor
Author
|
@echuraev There are some requirements and concerns on high load and unload timings with TVM in general. With PreCompiled bin we could reduce the majority and there exist some more scope with params loading. Unload time is also a bit significant. I am working on few improvements around these areas ... |
echuraev
approved these changes
Sep 28, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
LGTM! @srkreddy1238 just up to you if you want to return dynamic allocation or not. Feel free to merge this PR when the CI is green.
Contributor
Author
|
Never mind. While I was relooking into the code I found a reference of the deleted object and fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few fixes and enhancements that affects model loading times New options to measure performance.